Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back legacy precompile versions #2118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Apr 3, 2025

Describe your changes and provide context

Add back all historical versions of precompile code since mainnet launch (v5.0.1). In subsequent PRs, we will add logics to route tracing requests for historical transactions to the correct historical version of precompile code.

Testing performed to validate your change

no logic change; pure addition

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.68%. Comparing base (620c03b) to head (b7101cc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2118   +/-   ##
=======================================
  Coverage   61.67%   61.68%           
=======================================
  Files         272      272           
  Lines       25246    25246           
=======================================
+ Hits        15571    15573    +2     
  Misses       8530     8530           
+ Partials     1145     1143    -2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/versioned-precompiles branch from bdcfc6a to b7101cc Compare April 3, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant